Shield DPL workflows from FairMQDevice#1092
Merged
ktf merged 2 commits intoAliceO2Group:devfrom May 19, 2018
Merged
Conversation
Collaborator
|
Error while checking build/O2/o2-dev-fairroot for 2bb5019dd281db653a9df3cb10cf43c2c06e0779: Full log here. |
Collaborator
|
Error while checking build/o2checkcode/o2 for 2bb5019dd281db653a9df3cb10cf43c2c06e0779: Full log here. |
Because of its dependency on Boost mpl and Boost fusion, including FairMQDevice.h is very heavy duty for the compiler. This introduces a FairMQDeviceProxy class which hides FairMQDevice completely. As a bonus a round of cleanups of unneeded include statements (potentially using forward declarations instead) is also done.
Collaborator
|
Error while checking build/O2/o2-dev-fairroot for 2809505: Full log here. |
Collaborator
|
Error while checking build/o2checkcode/o2 for 2809505: Full log here. |
Collaborator
|
Error while checking build/O2/o2 for 2809505: Full log here. |
Collaborator
|
Error while checking build/O2/o2-dev-fairroot for d1a084a: Full log here. |
Collaborator
|
Error while checking build/o2checkcode/o2 for d1a084a: Full log here. |
Collaborator
|
Error while checking build/o2/macos for d1a084a: Full log here. |
Member
Author
|
Speed up confirmed by @aphecetche in https://alice-talk.web.cern.ch/t/very-slow-cmake-o2-installation-on-macos/68/16. Merging. |
ehellbar
pushed a commit
to ehellbar/AliceO2
that referenced
this pull request
Jun 7, 2018
Because of its dependency on Boost mpl and Boost fusion, including FairMQDevice.h is very heavy duty for the compiler. This introduces a FairMQDeviceProxy class which hides FairMQDevice completely. As a bonus a round of cleanups of unneeded include statements (potentially using forward declarations instead) is also done.
mikesas
pushed a commit
to mikesas/AliceO2
that referenced
this pull request
Dec 13, 2022
* support for control event histograms * fixing formatting * fixing formatting * fixing formatting * fixing formatting * fixing formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of its dependency on Boost mpl and Boost fusion,
including FairMQDevice.h is very heavy duty for the compiler.
Given that the FairMQDevice is not really needed, but only the Transport
and the correct serialization policy, we simply move to use those
directly.